Fix empty datasource schema on the Broker when metadata query is disabled #16645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoe
reviewed
Jun 25, 2024
| if (rowSignature.getColumnNames().isEmpty()) { | ||
| // this case could arise when metadata refresh is disabled on broker | ||
| // and a new datasource is added | ||
| log.info("datasource [%s] has empty signature.", dataSource); |
There was a problem hiding this comment.
Suggested change
| log.info("datasource [%s] has empty signature.", dataSource); | |
| log.info("datasource [%s] schema has not been initialized yet. If this happens continuously, check coordinator logs ", dataSource); |
| // this case could arise when metadata refresh is disabled on broker | ||
| // and a new datasource is added | ||
| log.info("datasource [%s] has empty signature.", dataSource); | ||
| continue; |
There was a problem hiding this comment.
Lets do table.remove(ds) ?
cryptoe
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: #14989
With the
CentralizedDatasourceSchemafeature, Broker polls datasource schema from the Coordinator.Datasource schema could be temporarily empty on the Broker in the following scenario,
In the period between Broker building empty datasource schema and polling correct schema from the Coordinator, queries start to fail with
column not foundexception.The fix is to avoid caching any datasource schema which is empty.
This PR also updates the datasource readiness check in the Standard ITs to ensure that the datasource schema is non-empty.