Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataSegment interning in SQLMetadataSegmentManager #7610

Closed

Conversation

surekhasaharan
Copy link

Addresses #6358

  • added trueEquals method to DataSegment to do complete equality check of DataSegment objects
  • make replaceWithExistingSegmentIfPresent in SQLMetadataSegmentManager usetrueEquals

@leventov leventov self-requested a review June 10, 2019 13:09
Copy link
Member

@leventov leventov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR doesn't appear to be complete to implement this plan: #6358 (comment). Also "trueEquals()" name is not objective. Suggested either "allDataEquals()", or "allMetadataEquals()", or "metadataEquals()".

@hellobabygogo
Copy link

this patch will case young gc and old gc pressure increase.

@stale
Copy link

stale bot commented Oct 23, 2019

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Oct 23, 2019
@stale
Copy link

stale bot commented Nov 20, 2019

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale bot closed this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants