New OBJECTARRAY implementation for SqlQuery.resultFormat
#8881
Conversation
sbespalov
force-pushed
the
issues/8816
branch
4 times, most recently
from
ccfc5e0
to
9124d13
Compare
|
@vogievetsky can you please have a look? |
| @@ -100,6 +100,20 @@ public Writer createFormatter(final OutputStream outputStream, final ObjectMappe | |||
| { | |||
| return new ObjectLinesWriter(outputStream, jsonMapper); | |||
| } | |||
| }, | |||
|
|
|||
| OBJECTARRAY { | |||
There was a problem hiding this comment.
This should be added to the doc page docs/querying/sql.md. I don't think the name is very clear though. Maybe "wrappedObject" would be clearer in relation to the other ones?
- object: array of objects
- array: array of arrays
- wrappedObject: object containing an array of objects
| @Override | ||
| public void writeResponseEnd() throws IOException | ||
| { | ||
| objectWriter.writeResponseEnd(false); |
There was a problem hiding this comment.
Instead of adding the new ObjectWriter#writeResponseEnd(boolean flush) method, IMO it makes more sense to simply call jsonGenerator.writeEndArray(); here. It reduces coupling between this class and ObjectWriter.
sbespalov
force-pushed
the
issues/8816
branch
from
d004481
to
3494908
Compare
sbespalov
force-pushed
the
issues/8816
branch
from
3494908
to
67d9e78
Compare
|
@gianm the build seems passed now |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
|
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Fixes #8816.
Description
This PR has:
Key changed/added classes in this PR
ResultFormat.WRAPPEDOBJECTWrappedObjectWriter