Imp: add Client.GetPendingResponse to limit the lock scope #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ut is failed. Pls try to"go test ./..." |
fangyincheng
reviewed
Jun 7, 2019
| @@ -201,6 +201,13 @@ func (c *Client) AsyncCall(addr string, svcUrl common.URL, method string, args i | |||
| return perrors.WithStack(c.call(CT_TwoWay, addr, svcUrl, method, args, reply, callback, copts)) | |||
| } | |||
|
|
|||
| func (c *Client) GetPendingResponse(seq SequenceType) *PendingResponse { | |||
There was a problem hiding this comment.
Is it better to change GetPendingResponse to getPendingResponse?
There was a problem hiding this comment.
No. It is invoked by other funcs.
There was a problem hiding this comment.
addPendingResponse and removePendingResponse both are lowercase . Should GetPendingResponse be called by other package ?
protocol/dubbo/codec.go
Outdated
| @@ -74,7 +74,7 @@ func (p *DubboPackage) Marshal() (*bytes.Buffer, error) { | |||
| } | |||
|
|
|||
| func (p *DubboPackage) Unmarshal(buf *bytes.Buffer, opts ...interface{}) error { | |||
| codec := hessian.NewHessianCodec(bufio.NewReaderSize(buf, buf.Len())) | |||
| codec := hessian.NewHessianCodec(bufio.NewReader(buf)) | |||
There was a problem hiding this comment.
ok. I will change back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: