Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-21021][python] Bump Beam to 2.27.0 #14741

Merged
merged 2 commits into from
Mar 4, 2021
Merged

[FLINK-21021][python] Bump Beam to 2.27.0 #14741

merged 2 commits into from
Mar 4, 2021

Conversation

HuangXingBo
Copy link
Contributor

What is the purpose of the change

This pull request will Bump Beam to 2.27.0

Brief change log

  • Bump Beam to 2.27.0

Verifying this change

This change added tests and can be verified as follows:

  • Original Tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1877658 (Sun Jan 24 12:16:59 UTC 2021)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 24, 2021 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@HuangXingBo HuangXingBo force-pushed the FLINK-21021 branch 3 times, most recently from c3fa1cd to a2be9be Compare January 25, 2021 05:02
@zentol
Copy link
Contributor

zentol commented Jan 26, 2021

@dianfu Will you take care of this PR?

@dianfu
Copy link
Contributor

dianfu commented Jan 27, 2021

@zentol Sure. Thanks for the reminder.

@dianfu dianfu self-assigned this Jan 27, 2021
@dianfu
Copy link
Contributor

dianfu commented Feb 22, 2021

@HuangXingBo Sorry for late response of this PR. There are some code conflicts. Could you help to rebase the PR to the latest master?

@HuangXingBo HuangXingBo force-pushed the FLINK-21021 branch 2 times, most recently from c349fa0 to a3191da Compare February 26, 2021 09:08
@HuangXingBo
Copy link
Contributor Author

@dianfu I have rebased the master and pushed again

dianfu
dianfu reviewed Mar 1, 2021
View reviewed changes
flink-python/setup.py Outdated
'pandas>=0.25.2,<1; python_full_version >= "3.5.3"',
'pyarrow>=0.15.1,<0.18.0', 'pytz>=2018.3', 'numpy>=1.14.3,<1.20'],
'pandas>=0.25.2,<1', 'pyarrow>=0.15.1,<0.18.0', 'pytz>=2018.3',
'numpy>=1.14.3,<1.20', 'fastavro>=0.21.4,<0.24'],
Copy link
Contributor

@dianfu dianfu Mar 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'numpy>=1.14.3,<1.20', 'fastavro>=0.21.4,<0.24'],
'numpy>=1.14.3,<1.21', 'fastavro>=0.21.4,<2'],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fastavro hasn't no longer provided manylinux2010.whl since 0.24.2, which makes some old version machines must have gcc if using newer version of fastavro. In fact, the fastavro dependency comes from apache-beam, and it is used in connectors. We can limit it to a relatively old version to solve the problem of gcc absence, and it will not have any impact on Pyflink. What do you think?

The 2.0.0 version of pyarrow is incompatible with the 1.20.x version of numpy. This problem was resolved in the unreleased 2.0.1 version of pyarrow. So here we limit the version of numpy to less than 1.20.
https://issues.apache.org/jira/browse/ARROW-10855?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel

flink-python/setup.py Outdated
'pandas>=0.24.2,<1; python_full_version < "3.5.3"',
'pandas>=0.25.2,<1; python_full_version >= "3.5.3"',
'pyarrow>=0.15.1,<0.18.0', 'pytz>=2018.3', 'numpy>=1.14.3,<1.20'],
'pandas>=0.25.2,<1', 'pyarrow>=0.15.1,<0.18.0', 'pytz>=2018.3',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'pandas>=0.25.2,<1', 'pyarrow>=0.15.1,<0.18.0', 'pytz>=2018.3',
'pandas>=1.0,<1.3.0', 'pyarrow>=0.15.1,<4.0.0', 'pytz>=2018.3',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 'pandas>=1.0,<1.2.0', 'pyarrow>=0.15.1,<3.0.0' is better, which is consistent with the dependency version of apache-beam

flink-python/setup.py Outdated
python_requires='>=3.5',
install_requires=['py4j==0.10.8.1', 'python-dateutil==2.8.0', 'apache-beam==2.23.0',
python_requires='>=3.6',
install_requires=['py4j==0.10.8.1', 'python-dateutil==2.8.0', 'apache-beam==2.27.0',
'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1', 'jsonpickle==1.2',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1', 'jsonpickle==1.2',
'cloudpickle==1.2.2', 'avro-python3>=1.8.1,!=1.9.2,<1.10.0', 'jsonpickle==1.2',

dianfu
dianfu approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@dianfu dianfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dianfu dianfu merged commit 0adc5c2 into apache:master Mar 4, 2021
autophagy pushed a commit to autophagy/flink that referenced this pull request Mar 16, 2021
@HuangXingBo @autophagy
[FLINK-21021][python] Bump Beam to 2.27.0 (apache#14741)
337a266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianfu dianfu dianfu approved these changes

Assignees

@dianfu dianfu

Labels
component=API/Python review=description?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HuangXingBo @flinkbot @zentol @dianfu @rmetzger