-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21592][table-planner-blink] RemoveSingleAggregateRule fails du… #15082
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 830b573 (Fri May 28 09:06:14 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
02251f1
to
cbbe20e
Compare
@@ -1353,6 +1353,38 @@ class TableEnvironmentTest { | |||
tableResult3.collect()) | |||
} | |||
|
|||
@Test | |||
def testRemoveSingleAggregateRule(): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you find another place to add the test? Adding this to TableEnvironmentTest
doesn't sound right to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved the test to a dedicated class RemoveSingleAggregateRuleTest
. Hopefully that makes things clearer.
…e to nullability mismatch
cbbe20e
to
ff86c77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e to nullability mismatch
What is the purpose of the change
Fix query plan failure due to RemoveSingleAggregateRule.
Brief change log
RemoveSingleAggregateRule::onMatch
Verifying this change
Added test case
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation