Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPCLIENT-2314: Handle gracefully a failure of DnsResolver to return a list of resolved addresses #533

Merged
merged 5 commits into from
Jan 7, 2024
Merged

HTTPCLIENT-2314: Handle gracefully a failure of DnsResolver to return a list of resolved addresses #533

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0212591
HTTPCLIENT-2314: better handling of DNS failure to resolve an address…
ok2c Jan 6, 2024
0004c56
Make sure to throw an UnknownHostException in case of empty result
phax Jan 7, 2024
eca6190
Throwing Exception in case no host was found
phax Jan 7, 2024
736ff35
Reverted changes from @ok2c
phax Jan 7, 2024
4bdb9ab
Added UnknownHostException on empty dnsResolver result
phax Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Throwing Exception in case no host was found
  • Loading branch information
@phax
phax committed Jan 7, 2024
commit eca6190ae131bb705fd4a4d95907c44616521760
2 changes: 1 addition & 1 deletion ...src/main/java/org/apache/hc/client5/http/impl/io/DefaultHttpClientConnectionOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public void connect(
if (LOG.isDebugEnabled()) {
LOG.debug("{} resolved to {}", host.getHostName(), remoteAddresses == null ? "null" : Arrays.asList(remoteAddresses));
}

if (remoteAddresses == null || remoteAddresses.length == 0) {
throw new UnknownHostException(host.getHostName());
}
Expand Down