Address review comments

apache · Jul 2, 2024 · 7525f36 · 7525f36
1 parent e4ff70c
commit 7525f36
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/AnalyzeTableSparkAction.java b/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/AnalyzeTableSparkAction.java
@@ -65,7 +65,7 @@ public class AnalyzeTableSparkAction extends BaseSparkAction<AnalyzeTableSparkAc
     Snapshot snapshot = table.currentSnapshot();
     if (snapshot == null) {
       LOG.error("Unable to analyze the table since the table has no snapshots");
-      throw new RuntimeException("Snapshot id is null");
+      throw new RuntimeException("Unable to analyze the table since the table has no snapshots");
     }
     this.snapshotId = snapshot.snapshotId();
     this.columns =

diff --git a/...3.5/spark/src/main/java/org/apache/iceberg/spark/actions/ThetaSketchJavaSerializable.java b/...3.5/spark/src/main/java/org/apache/iceberg/spark/actions/ThetaSketchJavaSerializable.java
@@ -101,10 +101,8 @@ static ThetaSketchJavaSerializable updateSketch(
 
   static ThetaSketchJavaSerializable combineSketch(
       ThetaSketchJavaSerializable sketch1, ThetaSketchJavaSerializable sketch2) {
-    ThetaSketchJavaSerializable emptySketchWrapped =
-        new ThetaSketchJavaSerializable(UpdateSketch.builder().build().compact());
     if (sketch1.getSketch() == null && sketch2.getSketch() == null) {
-      return emptySketchWrapped;
+      return new ThetaSketchJavaSerializable(UpdateSketch.builder().build().compact());
     }
     if (sketch1.getSketch() == null) {
       return sketch2;