Skip to content

Commit

Permalink
Build: Rename allVersions flag to allModules (#10499)
Browse files Browse the repository at this point in the history
The meaning of the flag is to enable all modules. In particular, it does
not enable all Scala versions for the build. The new name more directly
conveys the intent.
  • Loading branch information
findepi committed Jun 15, 2024
1 parent 42c3159 commit b7a0bea
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/java-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
with:
distribution: zulu
java-version: 8
- run: ./gradlew -DallVersions build -x test -x javadoc -x integrationTest
- run: ./gradlew -DallModules build -x test -x javadoc -x integrationTest

build-javadoc:
runs-on: ubuntu-22.04
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ jobs:
java-version: 8
- run: |
./gradlew printVersion
./gradlew -DallVersions publishApachePublicationToMavenRepository -PmavenUser=${{ secrets.NEXUS_USER }} -PmavenPassword=${{ secrets.NEXUS_PW }}
./gradlew -DallModules publishApachePublicationToMavenRepository -PmavenUser=${{ secrets.NEXUS_USER }} -PmavenPassword=${{ secrets.NEXUS_PW }}
./gradlew -DflinkVersions= -DsparkVersions=3.3,3.4,3.5 -DscalaVersion=2.13 -DhiveVersions= publishApachePublicationToMavenRepository -PmavenUser=${{ secrets.NEXUS_USER }} -PmavenPassword=${{ secrets.NEXUS_PW }}
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Iceberg is built using Gradle with Java 8, 11, or 17.
* To invoke a build and run tests: `./gradlew build`
* To skip tests: `./gradlew build -x test -x integrationTest`
* To fix code style for default versions: `./gradlew spotlessApply`
* To fix code style for all versions of Spark/Hive/Flink:`./gradlew spotlessApply -DallVersions`
* To fix code style for all versions of Spark/Hive/Flink:`./gradlew spotlessApply -DallModules`

Iceberg table support is organized in library modules:

Expand Down
2 changes: 1 addition & 1 deletion settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ project(':delta-lake').name = 'iceberg-delta-lake'
project(':kafka-connect').name = 'iceberg-kafka-connect'
project(':open-api').name = 'iceberg-open-api'

if (null != System.getProperty("allVersions")) {
if (null != System.getProperty("allModules")) {
System.setProperty("flinkVersions", System.getProperty("knownFlinkVersions"))
System.setProperty("sparkVersions", System.getProperty("knownSparkVersions"))
System.setProperty("hiveVersions", System.getProperty("knownHiveVersions"))
Expand Down

0 comments on commit b7a0bea

Please sign in to comment.