Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump Hive 2.3.10 #10447

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Build: Bump Hive 2.3.10 #10447

wants to merge 2 commits into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Jun 5, 2024

Hive 2.3.10 is the final release of branch-2.3, which focuses on mitigating CVE dependencies.

https://github.com/apache/hive/blob/rel/release-2.3.10/RELEASE_NOTES.txt

Spark upgraded Hive 2.3.10 in 4.0.0-preview1 via SPARK-47018

@pan3793 pan3793 changed the title Bump Hive 2.3.10 Build: Bump Hive 2.3.10 Jun 5, 2024
@pan3793 pan3793 marked this pull request as draft June 5, 2024 07:00
@pan3793
Copy link
Member Author

pan3793 commented Jun 5, 2024

Looks like there are issues about Jackson deps, and I'm surprised that testImplementation enforcedPlatform(libs.jackson212.bom) does not work ... maybe I need some help from a Gradle expert ...

@@ -68,8 +67,7 @@ project(':iceberg-mr') {
testImplementation libs.avro.avro
testImplementation libs.calcite.core
testImplementation libs.kryo.shaded
testImplementation platform(libs.jackson.bom)
testImplementation "com.fasterxml.jackson.core:jackson-annotations"
testImplementation enforcedPlatform(libs.jackson212.bom)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to apache/hive#4562 the Jackson version was switched to 2.9.4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually wondering how this worked in the first place with Jackson 2.14 and Hive 2.3.9

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was bumped to 2.12.0 soon apache/hive@2469d9e

and it should be compatible with 2.12 onwards ...

@@ -142,8 +142,8 @@ hive3-service = { module = "org.apache.hive:hive-service", version.ref = "hive3"
httpcomponents-httpclient5 = { module = "org.apache.httpcomponents.client5:httpclient5", version.ref = "httpcomponents-httpclient5" }
immutables-value = { module = "org.immutables:value", version.ref = "immutables-value" }
jackson-bom = { module = "com.fasterxml.jackson:jackson-bom", version.ref = "jackson-bom" }
jackson-core = { module = "com.fasterxml.jackson:jackson-core", version.ref = "jackson-bom" }
jackson-databind = { module = "com.fasterxml.jackson:jackson-databind", version.ref = "jackson-bom" }
jackson-core = { module = "com.fasterxml.jackson.core:jackson-core", version.ref = "jackson-bom" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase this PR please? I've fixed this in a642a93

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be irrelative, anyway, let me rebase it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants