-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Flink's SpeculativeExecution in batch execution mode #10548
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@venkata91 Thanks for the patch. Left a comment. It looks like there is a simpler approach.
...link/src/main/java/org/apache/iceberg/flink/source/enumerator/AbstractIcebergEnumerator.java
Outdated
Show resolved
Hide resolved
...link/src/main/java/org/apache/iceberg/flink/source/enumerator/AbstractIcebergEnumerator.java
Outdated
Show resolved
Hide resolved
bcc1550
to
347e25a
Compare
cc @stevenzwu for review. Should this change also be made in other Flink versions like Flink-1.17 and Flink-1.18? |
347e25a
to
7bcfdb2
Compare
@venkata91: How can we be sure that the tests are exercising the speculative execution code path? Does any of the tests reads some splits multiple times, and use the result of the faster one? I think it would be useful to have a test demonstrating that the behavior works, to prevent disabling it by an unrelated change by accident. |
Sure sounds good. Will add a test. |
Summary
Add support for Flink's Speculative Execution in batch execution mode
Testing
Existing tests should take care of it