Fix some long casting issues
#10580
Merged
Fix some long casting issues
#10580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
approved these changes
Jun 29, 2024
amogh-jahagirdar
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Thanks for cleaning this up @snazy. Feel free to raise the Flink backports separately.
| Math.floorDiv(value, 1000_000), Math.floorMod(value, 1000_000) * 1000) | ||
| Math.floorDiv(value, 1000_000), Math.floorMod(value, 1000_000) * 1000L) |
There was a problem hiding this comment.
Just keep in mind you'll want to backport this to the previous Flink versions
snazy
added a commit
to snazy/iceberg
that referenced
this pull request
Jul 4, 2024
Backport of apache#10580 and resolve IDE warning/error wrt `floorMod`/`floorDiv`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These locations popped up in IntelliJ, and the suggested fixes looked correct, so raising this PR.