Ability to build for all Scala versions #10606
Open
+898
−891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
all-scala-build
branch
5 times, most recently
from
53457b2
to
8d7edef
Compare
snazy
force-pushed
the
all-scala-build
branch
5 times, most recently
from
86e492b
to
cbc746b
Compare
snazy
force-pushed
the
all-scala-build
branch
3 times, most recently
from
80a06d6
to
7153e47
Compare
findepi
reviewed
Jul 1, 2024
| @@ -40,5 +40,4 @@ jobs: | |||
| java-version: 8 | |||
| - run: | | |||
| ./gradlew printVersion | |||
| ./gradlew -DallModules publishApachePublicationToMavenRepository -PmavenUser=${{ secrets.NEXUS_USER }} -PmavenPassword=${{ secrets.NEXUS_PW }} | |||
| ./gradlew -DflinkVersions= -DsparkVersions=3.3,3.4,3.5 -DscalaVersion=2.13 -DhiveVersions= publishApachePublicationToMavenRepository -PmavenUser=${{ secrets.NEXUS_USER }} -PmavenPassword=${{ secrets.NEXUS_PW }} | |||
| ./gradlew -DallModules=true -DallScalaVersions=true publishApachePublicationToMavenRepository -PmavenUser=${{ secrets.NEXUS_USER }} -PmavenPassword=${{ secrets.NEXUS_PW }} | |||
There was a problem hiding this comment.
-DallModules => -DallModules=true -- is this intentional change?
will -DallModules still have the effect it used to have?
There was a problem hiding this comment.
See https://github.com/apache/iceberg/pull/10606/files#diff-7f825392aa37acd1cee0c2e7b9bb7366ad6eac64f3e6cdd816e156bcb69d30deR92
It does not current old behavior
Forgive my ignorance. Does it affect the artifacts we build? Does it how we build them? Does it affect how we test them? |
There is no change in how things are built or tested. |
Allows building for all Spark/Scala version combinations. Introduces new system properties to control the behavior: * `allScalaVersions=true` lets Spark build for all Scala versions * the previous property `scalaVersion` is now a version list via the `scalaVersions` property, provides backwards compatibility * the previous property `defaultScalaVersion` is now a version list via the `defaultScalaVersions` property, provides backwards compatibility The defaults, via `gradle.properties` do not change. Also... * Unify processing of the xyzVersions everywhere * Fix compilation bug in Flink 1.19 jmh code (was not built before) * Update release jobs/script * Remove "hack" for `:iceberg-bom` * Simplify and fix related usages of the build system properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows building for all Spark/Scala version combinations. Introduces new system properties to control the behavior:
allScalaVersions=truelets Spark build for all Scala versionsscalaVersionis now a version list via thescalaVersionsproperty, provides backwards compatibilitydefaultScalaVersionis now a version list via thedefaultScalaVersionsproperty, provides backwards compatibilityThe defaults, via
gradle.propertiesdo not change.Also...
:iceberg-bom