Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport HadoopCatalog related classes in Flink #10620

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

tomtongue
Copy link
Contributor

Backport Flink 1.19 changes in #10358 to 1.17 and 1.18

Migrate the following classes in iceberg-flink to JUnit 5 for #9087

FlinkTestBase inherited classes:

  • TestFlinkIcebergSink
  • TestFlinkIcebergSinkBranch
  • TestFlinkIcebergSinkV2
  • TestFlinkIcebergSinkV2Branch
  • TestSqlBase
    • TestFlinkSourceSql
    • TestIcebergSourceSql
  • (HadoopTableResource related test) TestColumnStatsWatermarkExtractor and ReaderUtil

And newly created file for HadoopTableResource alternative:

  • HadoopTableExtension

@tomtongue tomtongue force-pushed the mig-junit5-flink-hadoop-backport branch from 384a8db to 68087da Compare July 2, 2024 15:30
@tomtongue
Copy link
Contributor Author

@nastra This PR is the backport to Flink 1.17 and 1.18 from the changes in Flink 1.19 we discussed in #10358. When you have a chance, could you review this PR?

@nastra
Copy link
Contributor

nastra commented Jul 2, 2024

LGTM, thanks @tomtongue for getting this done

@nastra nastra merged commit 0eab91a into apache:main Jul 2, 2024
19 checks passed
@tomtongue
Copy link
Contributor Author

Thanks for the quick review!

@tomtongue tomtongue deleted the mig-junit5-flink-hadoop-backport branch July 2, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants