Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: field_id in name serialisation spec should read field-id #11135

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Docs: field_id in name serialisation spec should read field-id #11135

merged 1 commit into from
Sep 19, 2024

Conversation

jonaswk
Copy link
Contributor

@jonaswk jonaswk commented Sep 14, 2024

Closes #11134

@github-actions github-actions bot added the Specification Issues that may introduce spec changes. label Sep 14, 2024
munendrasn
munendrasn approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@munendrasn munendrasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RussellSpitzer RussellSpitzer merged commit 79fd977 into apache:main Sep 19, 2024
2 checks passed
@RussellSpitzer
Copy link
Member

Thanks @jonaswk and @munendrasn for review! Since this is just a typo, I won't do a vote for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussellSpitzer RussellSpitzer RussellSpitzer approved these changes

@munendrasn munendrasn munendrasn approved these changes

Assignees
No one assigned
Labels
Specification Issues that may introduce spec changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name Mapping Serialisation Spec lists field field_id but examples use field-id
3 participants
@jonaswk @RussellSpitzer @munendrasn