Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SupportsBranches interface and initial impl w/ Nessie #2304

Closed
wants to merge 1 commit into from

Conversation

rymurr
Copy link
Contributor

@rymurr rymurr commented Mar 8, 2021

As per #1808 this introduces a SupportsBranches interface which allows catalogs to support CRUD operations on branches.

* is an immutable identifier to a specific point in the branching catalog's history. A branch can be modified, any
* catalog which plans to write or modify iceberg tables should set its reference to a branch.
*/
public interface Reference {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is how we want to do this interface/concrete classes. Not sure what the typical way to do this in iceberg is. In Nessie we use the Immutables library

@rymurr
Copy link
Contributor Author

rymurr commented Mar 29, 2021

@rdblue any thoughts on this one? This is as per #1808 and to isolate SQL extensions from actual nessie code.

I am ok w/ most of it but I am wondering if we really want a Reference in the interface it seems tightly coupled to git-like concepts

@rymurr
Copy link
Contributor Author

rymurr commented Apr 23, 2021

ping @rdblue was wondering what you thought of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant