Core: Defer reading Avro metadata until ManifestFile is read #5206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves job planning performance by moving
ManifestFiles.read
setup into theParallelIterator
that is used to plan tasks.ParallelIterator
accepts anIterable
ofCloseableIterable
. The outer iterable is iterated over to submit tasks that run in the worker pool. InManifestGroup
, theIterable
that was returned would callManifestFiles.read
to prepare the inner iterable, but theManifestReader
needs to read Avro file metadata and will open a stream. That initial file open was running in the consuming thread as tasks were submitted, instead of in the worker pool.This updates
ManifestGroup
to use a customIterable
that defers callingManifestFiles.read
until the inner iterable is used.