AWS: Add Option to don't write non current columns in glue schema closes #7584 #9420
+44
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raphael-Vignes
force-pushed
the
Raphael-Vignes/option-to-hide-non-current-field-in-glue
branch
from
c6f72b3
to
58c43a3
Compare
|
@Raphael-Vignes this seems like a good solution to the quoted issues. Anything keeping you from opening this for review? One point: I expect that the maintainers will want to keep the current behavior (i.e. writing the non-current columns) default, so you probably want to change your default. |
|
Sorry but I never finished this PR, I'm not sure it's fully functional. I'll try to finish it when I've time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close this issue and would resolve this issue too.
We want to provide an optional parameter to
IcebergToGlueConverter'ssetTableInputInformationmethod (set to false by default) namedglueCatalogWriteNonCurrentColumns. It will allow to skip writing columns that were deleted in previous version of the Glue Schema instead of writing and setting theiceberg.filed.currentvalue to false.