-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-17321 Add docs for java client partition awareness use cases #10453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/_docs/thin-clients/java-thin-client.adoc # modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java
timoninmaxim
requested changes
Feb 17, 2023
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java
Outdated
Show resolved
Hide resolved
docs/_docs/code-snippets/java/src/main/java/org/apache/ignite/snippets/JavaThinClient.java
Outdated
Show resolved
Hide resolved
# Conflicts: # docs/_docs/code-snippets/java/src/main/java/org/apache/ignite/snippets/JavaThinClient.java # docs/_docs/thin-clients/java-thin-client.adoc
timoninmaxim
requested changes
Mar 1, 2023
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java
Outdated
Show resolved
Hide resolved
timoninmaxim
reviewed
Mar 9, 2023
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java
Outdated
Show resolved
Hide resolved
timoninmaxim
reviewed
Mar 9, 2023
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java
Outdated
Show resolved
Hide resolved
timoninmaxim
reviewed
Mar 9, 2023
timoninmaxim
requested changes
Mar 9, 2023
docs/_docs/code-snippets/java/src/main/java/org/apache/ignite/snippets/JavaThinClient.java
Outdated
Show resolved
Hide resolved
timoninmaxim
approved these changes
Mar 10, 2023
timoninmaxim
changed the title
IGNITE-17321 Document which api can work with partition awareness
IGNITE-17321 Add docs for java client partition awareness use cases
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In javadoc org.apache.ignite.configuration.ClientConfiguration#partitionAwarenessEnabled and in the description of functionality
https://ignite.apache.org/docs/latest/thin-clients/java-thin-client#partition-awareness, it is not described with which api this functionality will work and in what cases. For example, will it work with getAll, in a transaction?
Describe in the documentation and in the javadoc in which cases it works and with which api.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summary
whereXXXX
- number of JIRA issue.(see the Maintainers list)
the
green visa
attached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.