-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-18834 Index rebuild ducktest #10561
Conversation
|
||
def get_file_sizes(nodes: list, file: str) -> dict: | ||
""" | ||
Return WAL size in bytes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/WAL/file/
def cache_dir(self, consistent_dir, cache_name): | ||
""" | ||
:param consistent_dir: consistent ID directory. | ||
:param cache_name: cachen name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/cachen/cache/
def index_file(self, consistent_dir, cache_name): | ||
""" | ||
:param consistent_dir: consistent ID directory. | ||
:param cache_name: cachen name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/cachen/cache/
qe.setValueType(VAL_TYPE); | ||
|
||
for (int j = 0; j < idxCnt; j++) { | ||
String field = "UUID" + j; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's replace it with byte array? In same manner as it's done for val. WDYT?
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summary
whereXXXX
- number of JIRA issue.(see the Maintainers list)
the
green visa
attached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.