IGNITE-13197: Import order rule added.

[nizhikov]

PR contains new checkstyle rule to check import order according to Ignite Code Style.
IntelliJ IDEA setup to match the check

The Contribution Checklist

• There is a single JIRA ticket related to the pull request.
• The web-link to the pull request is attached to the JIRA ticket.
• The JIRA ticket has the Patch Available state.
• The pull request body describes changes that have been made.
  The description explains WHAT and WHY was made instead of HOW.
• The pull request title is treated as the final commit message.
  The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
• A reviewer has been mentioned through the JIRA comments
  (see the Maintainers list)
• The pull request has been checked by the Teamcity Bot and
  the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

• How to Contribute
• Coding abbreviation rules
• Coding Guidelines
• Apache Ignite Teamcity Bot

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

[zaleslaw]

Could we create an XML checkstyle for IDEA or something else to make automatic refactoring?

[nizhikov]

@zaleslaw If you setup IDEA equal to screenshot then it will automatically rearrange imports according to codestyle(Code -> Optimize imports). All new imports will goes to the right place, also.

[zaleslaw]

So, I agree, but for newcomers it's a good point to have automatic checkstyle with all possible rules. I had one a year ago, but it doesn't cover all cases. If you have one, please let me know вт, 30 июн. 2020 г. в 17:51, Nikolay <notifications@github.com>:

…

@zaleslaw <https://github.com/zaleslaw> If you setup IDEA equal to screenshot <https://yadi.sk/i/kyXSE5rDc3ePOA> then it will automatically rearrange imports according to codestyle(Code -> Optimize imports). All new imports will goes to the right place, also. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7978 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJEUHNJ7FV5IB45BJM5FWLRZH3XJANCNFSM4OMJAKYQ> .

[nizhikov]

@zaleslaw We have automation in the form of maven checkstyle profile. The goal of this PR is to extend the coverage of automatic checks with the automatic Import Order rule. AFAIK checkstyle+maven is common solution and used in many other open-source projects.

Do you have in mind some other kind of automation?

[zaleslaw]

No automation, maybe it sounds wrong earlier: I suggest only shared community checkstyle.xml for using in IDEA (somebody shared one with me a few year ago, but now I lost it after moving on another laptop) вт, 30 июн. 2020 г. в 18:03, Nikolay <notifications@github.com>:

…

@zaleslaw <https://github.com/zaleslaw> We have automation in the form of maven checkstyle profile. The goal of this PR is to extend the coverage of automatic checks with the automatic Import Order rule. AFAIK checkstyle+maven is common solution and used in many other open-source projects. Do you have in mind some other kind of automation? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7978 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJEUHNA5SIT2MDO5HCHFUTRZH5D5ANCNFSM4OMJAKYQ> .

[nizhikov]

We have this file and it updated in PR.
Changes in settings.xml is the essence of PR

[zaleslaw]

Great, look like I missed the xml and saw only reordered imports in files вт, 30 июн. 2020 г. в 18:16, Nikolay <notifications@github.com>:

…

We have this file and it updated in PR. Changes in settings.xml is the essence of PR — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7978 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJEUHOZEN72MYK4I5PQ5W3RZH6WTANCNFSM4OMJAKYQ> .

[pavlukhin]

@nizhikov I see that travis build check failed and it seems that it is related to the import order rule (https://travis-ci.org/github/apache/ignite/builds/703548289?utm_source=github_status&utm_medium=notification). Could you please take a look?