Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dup 'From' in filterExpiredResultFromFromBackend #2207

Merged
merged 3 commits into from
May 8, 2023
Merged

fix: remove dup 'From' in filterExpiredResultFromFromBackend #2207

merged 3 commits into from
May 8, 2023

Conversation

KeeProMise
Copy link
Member

When I was debugging the code, I found that the name of the function filterExpiredResultFromFromBackend in the GraphTransaction.java file is problematic. Change the name.

@KeeProMise KeeProMise changed the title Modify function name Modify function name filterExpiredResultFromFromBackend in the GraphTransaction.java file May 8, 2023
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javeme javeme changed the title Modify function name filterExpiredResultFromFromBackend in the GraphTransaction.java file remove dup 'From' from filterExpiredResultFromFromBackend May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #2207 (bd90ce8) into master (267ff6d) will decrease coverage by 13.25%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master    #2207       +/-   ##
=============================================
- Coverage     61.53%   48.28%   -13.25%     
+ Complexity      484      379      -105     
=============================================
  Files           497      497               
  Lines         40572    40572               
  Branches       5663     5663               
=============================================
- Hits          24965    19590     -5375     
- Misses        13061    18805     +5744     
+ Partials       2546     2177      -369     
Impacted Files Coverage Δ
.../apache/hugegraph/backend/tx/GraphTransaction.java 74.30% <100.00%> (-5.38%) ⬇️

... and 147 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin imbajin changed the title remove dup 'From' from filterExpiredResultFromFromBackend fix:remove dup 'From' in filterExpiredResultFromFromBackend May 8, 2023
@imbajin imbajin changed the title fix:remove dup 'From' in filterExpiredResultFromFromBackend fix: remove dup 'From' in filterExpiredResultFromFromBackend May 8, 2023
@imbajin imbajin merged commit 0f2faf4 into apache:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants