Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenTracing 2.0 to get tracing and metrics capabilities #884

Open
zhangthen opened this issue Apr 24, 2019 · 5 comments
Open

Support OpenTracing 2.0 to get tracing and metrics capabilities #884

zhangthen opened this issue Apr 24, 2019 · 5 comments
Labels
task: help-wanted Extra attention is needed

Comments

@zhangthen
Copy link
Contributor

Why you need it?

Integrate OpenTracing 2.0 API to make Seata support tracing and metrics.

How it could be?

Modify seata‘s protocol to support context passing, and access OpenTracing 2.0 API .

Other related information

#714 , Except OpenTracing 2.0, we also need support SkyWalking .

@zhangthen zhangthen added the task: help-wanted Extra attention is needed label Apr 24, 2019
@zongtanghu
Copy link

Anybody do this?If nobody have interested in this pr,I want to have a try to contribute this pr.
@zhangthen @slievrly

@zhangthen
Copy link
Contributor Author

zhangthen commented May 16, 2019

Anybody do this?If nobody have interested in this pr,I want to have a try to contribute this pr.
@zhangthen @slievrly

No one do it yet, you can do it, welcome.

@zongtanghu
Copy link

zongtanghu commented May 16, 2019 via email

@zhangthen
Copy link
Contributor Author

zhangthen commented May 16, 2019

Hi, Can you give me some suggestion about this issue? huzongtang@cmss.chinamobile.com From: zhangthen Date: 2019-05-16 10:42 To: seata/seata CC: Hu Zongtang; Comment Subject: Re: [seata/seata] Support OpenTracing 2.0 to get tracing and metrics capabilities (#884) Anybody do this?If nobody have interested in this pr,I want to have a try to contribute this pr. @zhangthen @slievrly No one has done it yet, you can do it, welcome. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

I think that network and storage access in distributed transaction execution processes need burying points:

Transaction main stream:

1. start Transaction(Client->Server): DefaultGlobalTransaction.begin
2. registry branch(Client->Server): AbstractResourceManager.branchRegister
3. report branch(Client->Server): AbstractResourceManager.branchReport
4. Transaction commit(Client->Server): DefaultGlobalTransaction.commit
5. Transaction rollback(Client->Server) : DefaultGlobalTransaction.rollback
6. branch commit(Server->Client): DefaultCoordinator.branchCommit
7. branch rollback(Server->Client): DefaultCoordinator.branchRollback

Other stream:

8.is lockable check(Client->Server): DataSourceManager.lockQuery
9. store access of file: FileTransactionStoreManager (incude read & write)
10. store access of database: LogStoreDataBaseDAO (incude read & write)

@slievrly
Copy link
Member

ref #768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task: help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants