Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix:seata-server can's start in IDE. #1053

Merged
merged 3 commits into from
May 16, 2019
Merged

bugfix:seata-server can's start in IDE. #1053

merged 3 commits into from
May 16, 2019

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixex #1052

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi xingfudeshi requested review from zhangthen and slievrly and removed request for zhangthen May 16, 2019 02:29
@codecov-io
Copy link

codecov-io commented May 16, 2019 •
edited
Loading

Codecov Report

Merging #1053 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1053   +/-   ##
==========================================
  Coverage      38.49%   38.49%           
  Complexity      1077     1077           
==========================================
  Files            220      220           
  Lines           8772     8772           
  Branches        1108     1108           
==========================================
  Hits            3377     3377           
  Misses          4965     4965           
  Partials         430      430

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d60d1...a318e35. Read the comment docs.

@leizhiyuan
Copy link
Contributor

leizhiyuan commented May 16, 2019 •
edited
Loading

ps: the reason #942 (comment)

@zhangthen
Copy link
Contributor

Had fixed it in #942

@xingfudeshi
Copy link
Member Author

Had fixed it in #942

That PR hasn't been merged yet.We can fix it in this small PR ,otherwise the people who cloned the code and run the server in IDE will get confused.

slievrly
slievrly reviewed May 16, 2019
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check nacos registry is running normally.

lovepoem
lovepoem approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovepoem lovepoem merged commit 1c5a3ab into apache:develop May 16, 2019
@fescar-robot fescar-robot mentioned this pull request May 17, 2019
Closed
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@xingfudeshi @nick-tan
fix seata-server can's start in IDE. (apache#1053)
2bd15b7
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly approved these changes

@lovepoem lovepoem lovepoem approved these changes

@zhangthen zhangthen Awaiting requested review from zhangthen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.*
Development

Successfully merging this pull request may close these issues.
7 participants
@xingfudeshi @codecov-io @leizhiyuan @zhangthen @lovepoem @slievrly @wangliang181230