-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple environmental isolation #1075
Merged
Merged
Changes from 25 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
1994de6
Merge pull request #1 from seata/develop
XCXCXCXCX e9ae2c5
Merge branch 'develop' of https://github.com/seata/seata into develop
XCXCXCXCX 68afd1c
Merge pull request #2 from seata/develop
XCXCXCXCX 5941272
Merge branch 'develop' of https://github.com/XCXCXCXCX/seata into dev…
XCXCXCXCX 6219aa7
add: add time limit when transaction retry on the server
XCXCXCXCX 942b1df
fix: change int to long
XCXCXCXCX 93d0a56
Merge branch 'develop' into develop
xingfudeshi 8a8aa4f
add: Configuration api add getDuration()
XCXCXCXCX d43cdc0
Merge remote-tracking branch 'origin/develop' into develop
XCXCXCXCX a2d9275
add: copyright
XCXCXCXCX 4717fd7
fix: use test case instead main
XCXCXCXCX a0306c9
Merge branch 'develop' into develop
lovepoem 655cce7
add new config items to the nacos-config.txt
XCXCXCXCX 92f2000
Merge remote-tracking branch 'origin/develop' into develop
XCXCXCXCX 99f6f59
Merge branch 'develop' of https://github.com/seata/seata into develop
XCXCXCXCX cdab89c
Multiple environmental isolation
XCXCXCXCX b5304c5
fix
XCXCXCXCX 5b5d23e
fix conflict
XCXCXCXCX 744a8e6
Merge branch 'develop' into muti-env
XCXCXCXCX dde13dc
fix
XCXCXCXCX 70c166a
Merge branch 'develop' into muti-env
XCXCXCXCX 2657113
fix
XCXCXCXCX 1e715e1
Merge branch 'develop' into muti-env
xingfudeshi deacfd3
Merge branch 'develop' into muti-env
xingfudeshi b4433db
Merge branch 'develop' into muti-env
xingfudeshi 6e44356
Merge branch 'develop' into muti-env
xingfudeshi d2576c3
merge conflicts and add SEATA_CONFIG_ENV
XCXCXCXCX 7eb4317
add SEATA_CONFIG_ENV
XCXCXCXCX 46adf8d
Merge remote-tracking branch 'origin/muti-env' into muti-env
XCXCXCXCX 3532ced
Merge branch 'develop' of https://github.com/seata/seata into muti-env
XCXCXCXCX 10e4c9d
fix
XCXCXCXCX c38f2a5
fix
XCXCXCXCX e07995d
Merge branch 'develop' into muti-env
xingfudeshi b3ef5f5
Merge branch 'develop' into muti-env
xingfudeshi c93d1cf
Merge branch 'develop' into muti-env
xingfudeshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,11 +30,14 @@ | |
*/ | ||
public final class ConfigurationFactory { | ||
private static final Logger LOGGER = LoggerFactory.getLogger(ConfigurationFactory.class); | ||
private static final String REGISTRY_CONF = "registry.conf"; | ||
private static final String REGISTRY_CONF_PREFIX = "registry"; | ||
private static final String REGISTRY_CONF_SUFFIX = ".conf"; | ||
/** | ||
* The constant FILE_INSTANCE. | ||
*/ | ||
public static final Configuration FILE_INSTANCE = new FileConfiguration(REGISTRY_CONF); | ||
private static final String ENV_VALUE = System.getProperty("env"); | ||
private static final Configuration DEFAULT_FILE_INSTANCE = new FileConfiguration(REGISTRY_CONF_PREFIX + REGISTRY_CONF_SUFFIX); | ||
public static final Configuration CURRENT_FILE_INSTANCE = (ENV_VALUE == null || "default".equals(ENV_VALUE)) ? DEFAULT_FILE_INSTANCE : new FileConfiguration(REGISTRY_CONF_PREFIX + "-" + ENV_VALUE + REGISTRY_CONF_SUFFIX); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's better to define a constant for "default". |
||
private static final String NAME_KEY = "name"; | ||
private static final String FILE_TYPE = "file"; | ||
|
||
|
@@ -43,11 +46,11 @@ public final class ConfigurationFactory { | |
* | ||
* @return the instance | ||
*/ | ||
public static Configuration getInstance() { | ||
public static synchronized Configuration getInstance() { | ||
ConfigType configType = null; | ||
String configTypeName = null; | ||
try { | ||
configTypeName = FILE_INSTANCE.getConfig(ConfigurationKeys.FILE_ROOT_CONFIG + ConfigurationKeys.FILE_CONFIG_SPLIT_CHAR | ||
configTypeName = CURRENT_FILE_INSTANCE.getConfig(ConfigurationKeys.FILE_ROOT_CONFIG + ConfigurationKeys.FILE_CONFIG_SPLIT_CHAR | ||
+ ConfigurationKeys.FILE_ROOT_TYPE); | ||
configType = ConfigType.getType(configTypeName); | ||
} catch (Exception exx) { | ||
|
@@ -57,7 +60,7 @@ public static Configuration getInstance() { | |
String pathDataId = ConfigurationKeys.FILE_ROOT_CONFIG + ConfigurationKeys.FILE_CONFIG_SPLIT_CHAR | ||
+ FILE_TYPE + ConfigurationKeys.FILE_CONFIG_SPLIT_CHAR | ||
+ NAME_KEY; | ||
String name = FILE_INSTANCE.getConfig(pathDataId); | ||
String name = CURRENT_FILE_INSTANCE.getConfig(pathDataId); | ||
return new FileConfiguration(name); | ||
} else { | ||
return EnhancedServiceLoader.load(ConfigurationProvider.class, Objects.requireNonNull(configType).name()).provide(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you can provide a util class to set or resolve the env value
default it can fetch from system properties
when users use spring ,maybe they want to config from the application.properties ,so they can invoke your util method instead of use
System.setProperty
or pass by-D