add jackson serialization #1133

jsbxyyx · 2019-05-30T03:17:44Z

codecov-io · 2019-05-30T03:22:07Z

Codecov Report

Merging #1133 into develop will decrease coverage by <.01%.
The diff coverage is 37.73%.

@@              Coverage Diff              @@
##             develop    #1133      +/-   ##
=============================================
- Coverage      41.93%   41.92%   -0.01%     
- Complexity      1385     1390       +5     
=============================================
  Files            246      247       +1     
  Lines          10248    10282      +34     
  Branches        1343     1346       +3     
=============================================
+ Hits            4297     4311      +14     
- Misses          5387     5408      +21     
+ Partials         564      563       -1

Impacted Files	Coverage Δ	Complexity Δ
.../datasource/undo/parser/FastjsonUndoLogParser.java	`71.42% <0%> (ø)`	`3 <0> (ø)`	⬇️
...va/io/seata/rm/datasource/undo/UndoLogManager.java	`21.59% <18.18%> (+0.66%)`	`9 <1> (+1)`	⬆️
...m/datasource/undo/parser/JacksonUndoLogParser.java	`55.55% <55.55%> (ø)`	`4 <4> (?)`
.../java/io/seata/rm/datasource/DataCompareUtils.java	`72.3% <7.14%> (-11.91%)`	`24 <0> (ø)`
...o/seata/rm/datasource/sql/struct/TableRecords.java	`73.77% <77.77%> (+0.08%)`	`13 <1> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5afa229...63f6cbb. Read the comment docs.

slievrly

I will check sql type: timestamp date int(11) later

zhangthen · 2019-06-03T05:31:17Z

There was a PR (#1125 ) about adding protostuff as the serializer of UndoLogParser. JSON is inefficient, is it necessary to add a jackson serialization ?

slievrly · 2019-06-04T06:19:28Z

rm-datasource/src/test/java/io/seata/rm/datasource/undo/BaseH2Test.java

-import java.sql.SQLException;
-import java.sql.Statement;
-import java.sql.Types;
+import java.sql.*;


forbid to use *

slievrly · 2019-06-04T06:22:29Z

rm-datasource/src/main/java/io/seata/rm/datasource/DataCompareUtils.java

@@ -57,14 +55,6 @@ public static boolean isFieldEquals(Field f0, Field f1) {
                        if (f1.getValue() == null) {
                            return false;
                        } else {
-                            int f0Type = f0.getType();


I want to temporarily keep fastjson, can you make a judgment?

# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoLogParserFactory.java # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.undo.UndoLogParser # rm-datasource/src/test/java/io/seata/rm/datasource/undo/UndoLogParserFactoryTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/undo/UndoLogParserProviderTest.java

slievrly · 2019-06-04T12:01:16Z

Functional Verification: bigint(11), date, time, timestamp check ok.
CREATE TABLE test_jackson (
id int(11) NOT NULL AUTO_INCREMENT,
int_test bigint(11) DEFAULT NULL,
date_test date DEFAULT NULL,
time_test time DEFAULT NULL,
timespan_test timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
PRIMARY KEY (id)
) ENGINE=InnoDB AUTO_INCREMENT=4 DEFAULT CHARSET=utf8

slievrly · 2019-06-05T06:48:29Z

rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/JacksonUndoLogParser.java

+
+    @Override
+    public String getName() {
+        return "jackson";


Constant like fastjson

slievrly · 2019-06-05T06:50:03Z

rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoLogManager.java

@@ -187,6 +192,8 @@ public static void undo(DataSourceProxy dataSourceProxy, String xid, long branch
                            sqlUndoLog);
                        undoExecutor.executeOn(conn);
                    }
+                    // remove serializer name
+                    SERIALIZER_LOCAL.remove();


better add in finally block？

slievrly

LGTM

CoffeeLatte007

LGTM

alihack520 added 2 commits May 30, 2019 10:29

fix: #1116 fastjson serialization to jackson

995196e

fix jackson serialization TableRecords error

799538a

slievrly reviewed May 30, 2019

View reviewed changes

jsbxyyx and others added 4 commits May 30, 2019 16:40

Merge branch 'develop' into develop

83ead67

Merge branch 'develop' into develop

a863556

Merge branch 'develop' into develop

63ae168

Merge branch 'develop' into develop

08cd83d

slievrly reviewed Jun 4, 2019

View reviewed changes

alihack520 added 2 commits June 4, 2019 18:52

explicit import

a7eddac

slievrly and others added 4 commits June 4, 2019 20:17

Merge branch 'develop' into develop

65fe304

add compatible logic

bdb6d4a

Merge branch 'develop' of https://github.com/jsbxyyx/seata into develop

fd0dcfa

data compare add serializer name judgment

c3a0f0a

slievrly reviewed Jun 5, 2019

View reviewed changes

optimization judgment

63f6cbb

slievrly approved these changes Jun 5, 2019

View reviewed changes

CoffeeLatte007 approved these changes Jun 5, 2019

View reviewed changes

slievrly merged commit b7bc37f into apache:develop Jun 5, 2019

fescar-robot mentioned this pull request Jun 7, 2019

[WeeklyReport] Weekly report for Seata 2019-5-31 to 2019-6-7 #1182

Closed

nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019

add jackson undolog serialization (apache#1133)

7926008

wangliang181230 added this to the 0.7.* milestone Aug 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add jackson serialization #1133

add jackson serialization #1133

jsbxyyx commented May 30, 2019

codecov-io commented May 30, 2019 •

edited

Loading

slievrly left a comment

zhangthen commented Jun 3, 2019

slievrly Jun 4, 2019

slievrly Jun 4, 2019

slievrly commented Jun 4, 2019

slievrly Jun 5, 2019 •

edited

Loading

slievrly Jun 5, 2019

slievrly left a comment

CoffeeLatte007 left a comment

add jackson serialization #1133

add jackson serialization #1133

Conversation

jsbxyyx commented May 30, 2019

codecov-io commented May 30, 2019 • edited Loading

Codecov Report

slievrly left a comment

Choose a reason for hiding this comment

zhangthen commented Jun 3, 2019

slievrly Jun 4, 2019

Choose a reason for hiding this comment

slievrly Jun 4, 2019

Choose a reason for hiding this comment

slievrly commented Jun 4, 2019

slievrly Jun 5, 2019 • edited Loading

Choose a reason for hiding this comment

slievrly Jun 5, 2019

Choose a reason for hiding this comment

slievrly left a comment

Choose a reason for hiding this comment

CoffeeLatte007 left a comment

Choose a reason for hiding this comment

codecov-io commented May 30, 2019 •

edited

Loading

slievrly Jun 5, 2019 •

edited

Loading