Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support preparedStatement batch self-increment(need jdbc2+) #1371

Merged
merged 3 commits into from
Aug 3, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Jul 31, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jul 31, 2019

Codecov Report

Merging #1371 into develop will increase coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1371      +/-   ##
=============================================
+ Coverage      45.72%   45.87%   +0.14%     
  Complexity      1660     1660              
=============================================
  Files            345      345              
  Lines          12360    12360              
  Branches        1535     1562      +27     
=============================================
+ Hits            5652     5670      +18     
+ Misses          6058     6057       -1     
+ Partials         650      633      -17
Impacted Files Coverage Δ Complexity Δ
...o/seata/rm/datasource/AbstractConnectionProxy.java 4.76% <0%> (ø) 1 <0> (ø) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.77% <0%> (-0.79%) 24% <0%> (ø)
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+1.39%) 19% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterTMResponseConvertor.java 84.84% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterRMResponseConvertor.java 84.84% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...otobuf/convertor/GlobalBeginResponseConvertor.java 96.96% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...obuf/convertor/BranchRollbackRequestConvertor.java 96.42% <0%> (+3.57%) 3% <0%> (ø) ⬇️
...otobuf/convertor/BranchCommitRequestConvertor.java 100% <0%> (+3.57%) 3% <0%> (ø) ⬇️
...otobuf/convertor/BranchReportRequestConvertor.java 96.29% <0%> (+3.7%) 3% <0%> (ø) ⬇️
...protobuf/convertor/RegisterRMRequestConvertor.java 95.83% <0%> (+4.16%) 3% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63afbd1...bf0799e. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test takes effect under PreparedStatement,but how to take effect in the Statement?

@slievrly slievrly changed the title support batch self-increment(need jdbc2+) support preparedStatement batch self-increment(need jdbc2+) Aug 1, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit df7772a into apache:develop Aug 3, 2019
@zjinlei zjinlei deleted the feature/batchInsert-AI branch August 16, 2019 12:31
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants