-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: binding public network address listen failed #1505
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1505 +/- ##
=============================================
+ Coverage 46.39% 46.42% +0.02%
+ Complexity 1693 1692 -1
=============================================
Files 348 348
Lines 12729 12722 -7
Branches 1588 1588
=============================================
Hits 5906 5906
+ Misses 6184 6177 -7
Partials 639 639
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If configuring IP is no longer supported, remove all relevant logic.like setHost,getHost.
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemotingServer.java
Show resolved
Hide resolved
Considering the actual business scenario, Seata no longer supports specific IP for binding. |
Signed-off-by: slievrly <slievrly@163.com>
In the business scenario, a VIP external service is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I misunderstand your meaning,yes,the SERVER_DEFAULT_BIND_IP should be removed as it's no more required. |
Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment.
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix:binding public network address listen failed.
sh seata-server.sh -h $PUBLIC_ADDRESS_IP -p 8091 -m file
Ⅱ. Does this pull request fix one issue?
fix #1504
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews