Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: binding public network address listen failed #1505

Merged
merged 6 commits into from
Aug 28, 2019
Merged

bugfix: binding public network address listen failed #1505

merged 6 commits into from
Aug 28, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix:binding public network address listen failed.

sh seata-server.sh -h $PUBLIC_ADDRESS_IP -p 8091 -m file

Ⅱ. Does this pull request fix one issue?

fix #1504

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Aug 20, 2019

Codecov Report

Merging #1505 into develop will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1505      +/-   ##
=============================================
+ Coverage      46.39%   46.42%   +0.02%     
+ Complexity      1693     1692       -1     
=============================================
  Files            348      348              
  Lines          12729    12722       -7     
  Branches        1588     1588              
=============================================
  Hits            5906     5906              
+ Misses          6184     6177       -7     
  Partials         639      639
Impacted Files Coverage Δ Complexity Δ
server/src/main/java/io/seata/server/Server.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...src/main/java/io/seata/server/ParameterParser.java 53.57% <ø> (-1.61%) 6 <0> (ø)
...eata/core/rpc/netty/AbstractRpcRemotingServer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 53.21% <0%> (-0.92%) 28% <0%> (-1%)
...server/store/file/FileTransactionStoreManager.java 47.03% <0%> (+1.04%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce77a62...3705cf7. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If configuring IP is no longer supported, remove all relevant logic.like setHost,getHost.

@xingfudeshi
Copy link
Member

Considering the actual business scenario, Seata no longer supports specific IP for binding.

Signed-off-by: slievrly <slievrly@163.com>
@slievrly
Copy link
Member Author

Considering the actual business scenario, Seata no longer supports specific IP for binding.

In the business scenario, a VIP external service is required.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi
Copy link
Member

xingfudeshi commented Aug 28, 2019

please remove ParameterParser SERVER_DEFAULT_BIND_IP

I misunderstand your meaning,yes,the SERVER_DEFAULT_BIND_IP should be removed as it's no more required.

@apache apache deleted a comment from zjinlei Aug 28, 2019
@xingfudeshi
Copy link
Member

Here
image
the description need to be updated,"The IP to register to registry."

Signed-off-by: slievrly <slievrly@163.com>
@slievrly
Copy link
Member Author

Here
image
the description need to be updated,"The IP to register to registry."

fixed

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment.

server/src/main/java/io/seata/server/ParameterParser.java Outdated Show resolved Hide resolved
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 3b71ca4 into apache:develop Aug 28, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binding public network listen failed
5 participants