-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: delay to delete the expired undo log #1559
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1559 +/- ##
=============================================
- Coverage 46.42% 46.35% -0.08%
+ Complexity 1692 1690 -2
=============================================
Files 348 348
Lines 12723 12723
Branches 1588 1588
=============================================
- Hits 5907 5898 -9
- Misses 6177 6186 +9
Partials 639 639
Continue to review full report at Codecov.
|
@@ -459,7 +459,7 @@ public void init() { | |||
} catch (Exception e) { | |||
LOGGER.info("Exception undoLog deleting ... ", e); | |||
} | |||
},0, UNDOLOG_DELETE_PERIOD,TimeUnit.MILLISECONDS); | |||
},3 * 60 * 1000, UNDOLOG_DELETE_PERIOD, TimeUnit.MILLISECONDS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
define a constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
optimize delay to delete the expired undo log
Ⅱ. Does this pull request fix one issue?
fixes #1464
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews