Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: once delete GlobalSession locks for db mode when commit success #1574

Merged
merged 9 commits into from
Sep 7, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Aug 31, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 31, 2019

Codecov Report

Merging #1574 into develop will increase coverage by 0.02%.
The diff coverage is 54.16%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1574      +/-   ##
=============================================
+ Coverage      46.42%   46.44%   +0.02%     
- Complexity      1714     1717       +3     
=============================================
  Files            350      350              
  Lines          12829    12847      +18     
  Branches        1615     1618       +3     
=============================================
+ Hits            5956     5967      +11     
- Misses          6225     6232       +7     
  Partials         648      648
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 84.54% <100%> (-0.08%) 67 <2> (ø)
.../java/io/seata/server/lock/DefaultLockManager.java 52.27% <50%> (-7.73%) 12 <4> (+3)
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+1.39%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b350b36...4ee581b. Read the comment docs.

@zjinlei zjinlei changed the title optimize: batch delete GlobalSession locks for db mode when commit success optimize: once delete GlobalSession locks for db mode when commit success Aug 31, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi closed this Sep 6, 2019
@xingfudeshi xingfudeshi reopened this Sep 6, 2019
@zjinlei zjinlei merged commit e191caa into apache:develop Sep 7, 2019
@zjinlei zjinlei deleted the optimize/batchDeleteLockForDB branch September 7, 2019 06:17
@zjinlei zjinlei added the theme: performance An issue or pr that we don't feel is valid label Nov 25, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: performance An issue or pr that we don't feel is valid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants