-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: sql statement escape symbol #1668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1668 +/- ##
=============================================
+ Coverage 54.95% 55.34% +0.39%
- Complexity 2472 2504 +32
=============================================
Files 444 445 +1
Lines 14809 14838 +29
Branches 1749 1749
=============================================
+ Hits 8138 8212 +74
+ Misses 5921 5862 -59
- Partials 750 764 +14
|
slievrly
reviewed
Sep 18, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/ColumnUtils.java
Outdated
Show resolved
Hide resolved
xingfudeshi
approved these changes
Sep 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UTs are passed.LGTM.
jsbxyyx
changed the title
bugfix insert column have escape symbol
bugfix insert column has escape symbol
Sep 25, 2019
jsbxyyx
changed the title
bugfix insert column has escape symbol
bugfix insert column has escape symbol and oracle batch insert
Sep 25, 2019
…insert_back_quote
slievrly
reviewed
Oct 8, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/AbstractConnectionProxy.java
Outdated
Show resolved
Hide resolved
jsbxyyx
changed the title
bugfix insert column has escape symbol and oracle batch insert
bugfix insert column has escape symbol
Oct 8, 2019
jsbxyyx
changed the title
bugfix: insert column has escape symbol
bugfix: insert column and table name has escape symbol
Oct 21, 2019
…insert_back_quote
zjinlei
reviewed
Dec 15, 2019
common/src/test/java/io/seata/common/exception/FrameworkExceptionTest.java
Outdated
Show resolved
Hide resolved
...-seata/src/main/java/io/seata/codec/seata/protocol/transaction/GlobalReportRequestCodec.java
Outdated
Show resolved
Hide resolved
config/seata-config-core/src/main/java/io/seata/config/ConfigurationFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/NettyPoolableFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/RmMessageListener.java
Outdated
Show resolved
Hide resolved
integration/dubbo/src/main/java/io/seata/integration/dubbo/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/seata/integration/grpc/interceptor/server/ServerTransactionInterceptor.java
Outdated
Show resolved
Hide resolved
integration/motan/src/main/java/io/seata/integration/motan/MotanTransactionFilter.java
Outdated
Show resolved
Hide resolved
...n/sofa-rpc/src/main/java/io/seata/integration/sofa/rpc/TransactionContextConsumerFilter.java
Outdated
Show resolved
Hide resolved
...n/sofa-rpc/src/main/java/io/seata/integration/sofa/rpc/TransactionContextProviderFilter.java
Outdated
Show resolved
Hide resolved
zjinlei
reviewed
Dec 16, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/ColumnUtils.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/ColumnUtils.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/ColumnUtils.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/ColumnUtils.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/AbstractUndoExecutor.java
Outdated
Show resolved
Hide resolved
jsbxyyx
changed the title
bugfix: insert column and table name has escape symbol
bugfix: sql statement escape symbol
Dec 16, 2019
zjinlei
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
bugfix:
Ⅱ. Does this pull request fix one issue?
fixes #1665 #1667 #1655
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews