Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: revision -> project version #1675

Merged
merged 2 commits into from
Sep 19, 2019
Merged

bugfix: revision -> project version #1675

merged 2 commits into from
Sep 19, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Sep 18, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: revision -> project version

cause the variable name to not be replaced in pom.xml when released.

image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #1675 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1675      +/-   ##
=============================================
- Coverage      47.17%   47.16%   -0.02%     
+ Complexity      1779     1778       -1     
=============================================
  Files            362      362              
  Lines          13237    13237              
  Branches        1641     1641              
=============================================
- Hits            6245     6243       -2     
- Misses          6316     6317       +1     
- Partials         676      677       +1
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 50% <0%> (-0.91%) 26% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 451bb01...85112ce. Read the comment docs.

Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lovepoem lovepoem merged commit 2376b8c into apache:develop Sep 19, 2019
@wangliang181230 wangliang181230 added this to the 0.9.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants