bugfix: fix use 'in' and 'between' in where condition for Oracle and Mysql #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1699 +/- ##
=============================================
+ Coverage 48.42% 50.06% +1.63%
- Complexity 2036 2130 +94
=============================================
Files 409 411 +2
Lines 14234 14200 -34
Branches 1726 1713 -13
=============================================
+ Hits 6893 7109 +216
+ Misses 6633 6401 -232
+ Partials 708 690 -18
Continue to review full report at Codecov.
|
slievrly
reviewed
Sep 25, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/sql/druid/oracle/OracleDeleteRecognizer.java
Outdated
Show resolved
Hide resolved
l81893521
changed the title
…re_condition_oracle_1 # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/sql/druid/MySQLDeleteRecognizer.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/druid/MySQLSelectForUpdateRecognizer.java
slievrly
reviewed
Oct 8, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/sql/druid/oracle/BaseOracleRecognizer.java
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/sql/druid/oracle/BaseOracleRecognizer.java
Show resolved
Hide resolved
dangquocbang
pushed a commit
to dangquocbang/seata
that referenced
this pull request
Oct 14, 2019
* 'develop' of https://github.com/seata/seata: test: enhance test coverage of seata common (apache#1755) security: upgrade jackson to avoid security vulnerabilities (apache#1756) bugfix:rm channel register null resource (apache#1401) bugfix:fix memory lock is not released due to hash conflict (apache#1751) optimize:use raw types instead of boxing types (apache#1747) change get charset (apache#1707) fix undo support oracle table meta cache (apache#1749) bugfix: fix use 'in' and 'between' in where condition for Oracle and Mysql (apache#1699) optimize:add some server's jvm parameters (apache#1738) Saga implementation base on state machine (apache#1608) optimize:inner class may be static (apache#1706) feature: retry when tm commit or rollback failed (apache#1739) optimize: abstract common undolog manager method (apache#1712) bugfix: when tm commit or rollback failed,xid need to be clean (apache#1735) optimize: eliminate the possibility of allocating too much direct memory (apache#1657) Based on Java 5 optimization (apache#1705) bugfix: oracle batch insert error (apache#1729) # Conflicts: # pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix where condition like
or
Ⅱ. Does this pull request fix one issue?
#1697 #1714
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews