-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:add seata-spring-boot-starter #1742
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1742 +/- ##
=============================================
+ Coverage 55.06% 55.08% +0.02%
Complexity 2355 2355
=============================================
Files 421 421
Lines 14264 14264
Branches 1710 1710
=============================================
+ Hits 7854 7858 +4
+ Misses 5682 5680 -2
+ Partials 728 726 -2
|
...arter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/SpringProperties.java
Show resolved
Hide resolved
...arter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/SpringProperties.java
Outdated
Show resolved
Hide resolved
...rter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/SupportProperties.java
Outdated
Show resolved
Hide resolved
...in/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryEurekaProperties.java
Outdated
Show resolved
Hide resolved
...ain/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryNacosProperties.java
Outdated
Show resolved
Hide resolved
...a-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/StarterConstants.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java
Outdated
Show resolved
Hide resolved
...ain/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryRedisProperties.java
Show resolved
Hide resolved
please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test pass. LGTM
sure.i will check. |
config/seata-config-core/src/main/java/io/seata/config/ConfigurationFactory.java
Outdated
Show resolved
Hide resolved
...arter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/ClientProperties.java
Show resolved
Hide resolved
...rter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/ServiceProperties.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/io/seata/spring/boot/autoconfigure/properties/registry/ConfigProperties.java
Outdated
Show resolved
Hide resolved
...ain/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryEecd3Properties.java
Outdated
Show resolved
Hide resolved
This reverts commit efe00ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -44,6 +44,7 @@ | |||
<module>tm</module> | |||
<module>metrics</module> | |||
<module>codec</module> | |||
<module>seata-spring-boot-starter</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need with seata prefix?
*/ | ||
@ComponentScan(basePackages = "io.seata.spring.boot.autoconfigure.properties") | ||
@ConditionalOnProperty(prefix = StarterConstants.SEATA_PREFIX, name = "enabled", matchIfMissing = true) | ||
@ConditionalOnClass({DataSourceProxy.class}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not contains AT mode.
* @date 2019/09/30 | ||
*/ | ||
@ComponentScan(basePackages = "io.seata.spring.boot.autoconfigure.properties") | ||
@ConditionalOnProperty(prefix = StarterConstants.SEATA_PREFIX, name = "enabled", matchIfMissing = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check seata.enable value.
Ⅰ. Describe what this PR did
Support spring-boot auto configuration of Seata.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done integration test with spring-boot 2.1.4.RELEASE and spring-boot 1.5.22.RELEASE
Ⅳ. Describe how to verify it
If your project uses spring-boot, just add the following dependency to the pom.
In your application.yml
Or application.properties
Other configurations have default values.
Ⅴ. Special notes for reviews