-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: transform desinger json to statemachine standard json #1958
Merged
long187
merged 7 commits into
apache:develop
from
long187:saga_transform_designer_json_iss1948
Dec 2, 2019
Merged
feature: transform desinger json to statemachine standard json #1958
long187
merged 7 commits into
apache:develop
from
long187:saga_transform_designer_json_iss1948
Dec 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/long187/seata into saga_transform_designer_json_iss1948
Codecov Report
@@ Coverage Diff @@
## develop #1958 +/- ##
=============================================
+ Coverage 55.3% 55.49% +0.18%
- Complexity 2409 2436 +27
=============================================
Files 429 430 +1
Lines 14278 14397 +119
Branches 1676 1707 +31
=============================================
+ Hits 7897 7989 +92
- Misses 5673 5682 +9
- Partials 708 726 +18
|
slievrly
approved these changes
Nov 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
long187
changed the title
transform desinger json to statemachine standard json
feature: transform desinger json to statemachine standard json
Nov 29, 2019
zhangthen
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
We provided a Saga StateMachine Designer, State language json generated by the Designer has layout informations. We need transform it to standard Saga State language json.
Ⅱ. Does this pull request fix one issue?
#1948
Ⅳ. Describe how to verify it
run unit test at test/src/test/java/io/seata/saga/engine/StateMachineTests.java
Ⅴ. Special notes for reviews
The Json generated by the designer is different from the standard Json of the Saga state machine (because the json generated by the designer has layout information), This PR is In order to make the state machine can be directly loaded and it will be converted into the Json of the Saga state machine standard.