-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: Flatten Saga nested transactions #1975
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1975 +/- ##
=============================================
+ Coverage 55.31% 55.32% +<.01%
+ Complexity 2439 2437 -2
=============================================
Files 434 434
Lines 14469 14470 +1
Branches 1706 1707 +1
=============================================
+ Hits 8004 8005 +1
+ Misses 5743 5742 -1
- Partials 722 723 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Saga nested transaction(SubState Machine)will create a new Global transaction, it is not necessary, We need make it Flatten.
Ⅱ. Does this pull request fix one issue?
#1974
Ⅳ. Describe how to verify it
run unit test at seata/test/src/test/java/io/seata/saga