review update

codec/seata-codec-hessian/pom.xml

@@ -1,4 +1,19 @@
 <?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~  Copyright 1999-2019 Seata.io Group.
+  ~
+  ~  Licensed under the Apache License, Version 2.0 (the "License");
+  ~  you may not use this file except in compliance with the License.
+  ~  You may obtain a copy of the License at
+  ~
+  ~       http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~  Unless required by applicable law or agreed to in writing, software
+  ~  distributed under the License is distributed on an "AS IS" BASIS,
+  ~  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~  See the License for the specific language governing permissions and
+  ~  limitations under the License.
+  -->
 <project xmlns="http://maven.apache.org/POM/4.0.0"
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
@@ -18,7 +33,7 @@
         <dependency>
             <groupId>io.seata</groupId>
             <artifactId>seata-core</artifactId>
-            <version>1.0.0-SNAPSHOT</version>
+            <version>${project.version}</version>
             <scope>compile</scope>
         </dependency>
     </dependencies>

codec/seata-codec-hessian/src/main/java/io/seata/codec/hessian/HessianCodec.java

@@ -17,7 +17,6 @@
 
 import com.caucho.hessian.io.Hessian2Input;
 import com.caucho.hessian.io.Hessian2Output;
-import com.caucho.hessian.io.HessianProtocolException;
 import com.caucho.hessian.io.Serializer;
 import com.caucho.hessian.io.SerializerFactory;
 import io.seata.common.loader.LoadLevel;
@@ -34,7 +33,7 @@
  */
 @LoadLevel(name = "HESSIAN")
 public class HessianCodec implements Codec {
-    private final Logger logger = LoggerFactory.getLogger(HessianCodec.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(HessianCodec.class);
 
     @Override
     public <T> byte[] encode(T t) {
@@ -47,32 +46,22 @@ public <T> byte[] encode(T t) {
             serializer.writeObject(t, output);
             output.close();
             stream = baos.toByteArray();
-        } catch (HessianProtocolException e) {
-            logger.error("Hessian encode error", e);
         } catch (IOException e) {
-            logger.error("Hessian encode error", e);
+            LOGGER.error("Hessian encode error", e);
         }
         return stream;
     }
 
     @Override
     public <T> T decode(byte[] bytes) {
-        Hessian2Input input = null;
-        try {
-            ByteArrayInputStream is = new ByteArrayInputStream(bytes);
-            input = new Hessian2Input(is);
-            try {
-                return (T) input.readObject();
-            } catch (IOException e) {
-                logger.error("Hessian decode error", e);
-            }
-        } finally {
-            try {
-                input.close();
-            } catch (IOException e) {
-                logger.error("Hessian decode error", e);
-            }
+        T obj = null;
+        try (ByteArrayInputStream is = new ByteArrayInputStream(bytes);) {
+            Hessian2Input input = new Hessian2Input(is);
+            obj = (T) input.readObject();
+            input.close();
+        } catch (IOException e) {
+            LOGGER.error("Hessian decode error", e);
         }
-        return null;
+        return obj;
     }
 }