feature: support ConsistentHashLoadBalance #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2080 +/- ##
=============================================
+ Coverage 51.06% 51.14% +0.07%
- Complexity 2764 2768 +4
=============================================
Files 550 551 +1
Lines 17525 17574 +49
Branches 2064 2070 +6
=============================================
+ Hits 8949 8988 +39
- Misses 7735 7743 +8
- Partials 841 843 +2
|
zjinlei
reviewed
Feb 29, 2020
config/seata-config-core/src/main/java/io/seata/config/ConfigurationKeys.java
Outdated
Show resolved
Hide resolved
ph3636
changed the title
# Conflicts: # core/src/main/java/io/seata/core/rpc/RemotingClient.java # core/src/main/java/io/seata/core/rpc/netty/AbstractNettyRemotingClient.java # rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceManager.java
l81893521
reviewed
Jul 27, 2020
...ry/seata-discovery-core/src/main/java/io/seata/discovery/loadbalance/LoadBalanceFactory.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jul 28, 2020
...ry/seata-discovery-core/src/main/java/io/seata/discovery/loadbalance/LoadBalanceFactory.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jul 28, 2020
...ry/seata-discovery-core/src/main/java/io/seata/discovery/loadbalance/LoadBalanceFactory.java
Outdated
Show resolved
Hide resolved
|
@ph3636 There are cyclic dependencies. |
done |
added 3 commits
August 5, 2020 15:49
# Conflicts: # seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/properties/client/RmProperties.java
|
根据TC列表做一层缓存吧， 每次都新建虚拟节点是不是性能会受到影响？ 比如配置3台TC， 配置160个虚拟节点， 每个请求都要多480个循环， 听起来就没必要嘛 |
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support ConsistentHashLoadBalance
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews