Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: some typos #2120

Merged
merged 2 commits into from
Jan 2, 2020
Merged

optimize: some typos #2120

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b72e4
optimize: some typos
EZKAYOTWJPRKXWCUYEEB Jan 1, 2020
10defbd
Merge branch 'develop' into patch-5
zjinlei Jan 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions metrics/seata-metrics-core/src/main/java/io/seata/metrics/exporter/ExporterType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ public enum ExporterType {
/**
* Export metrics data to Prometheus
*/
Prometheus;
PROMETHEUS;

public static ExporterType getType(String name) {
if (Prometheus.name().equalsIgnoreCase(name)) {
return Prometheus;
if (PROMETHEUS.name().equalsIgnoreCase(name)) {
return PROMETHEUS;
} else {
throw new NotSupportYetException("unsupported type:" + name);
}
Expand Down
6 changes: 3 additions & 3 deletions metrics/seata-metrics-core/src/main/java/io/seata/metrics/registry/RegistryType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ public enum RegistryType {
/**
* Built-in compact metrics registry
*/
Compact;
COMPACT;

public static RegistryType getType(String name) {
if (Compact.name().equalsIgnoreCase(name)) {
return Compact;
if (COMPACT.name().equalsIgnoreCase(name)) {
return COMPACT;
} else {
throw new NotSupportYetException("unsupported type:" + name);
}
Expand Down
2 changes: 1 addition & 1 deletion ...ter-prometheus/src/main/java/io/seata/metrics/exporter/prometheus/PrometheusExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public List<MetricFamilySamples> collect() {
List<Sample> samples = new ArrayList<>();
measurements.forEach(measurement -> samples.add(convertMeasurementToSample(measurement)));

if (samples.size() != 0) {
if (!samples.isEmpty()) {
familySamples.add(new MetricFamilySamples("seata", Type.UNTYPED, "seata", samples));
}
}
Expand Down