-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. #2151
Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. #2151
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2151 +/- ##
=============================================
+ Coverage 54.37% 54.41% +0.03%
- Complexity 2467 2469 +2
=============================================
Files 445 445
Lines 14751 14742 -9
Branches 1736 1734 -2
=============================================
+ Hits 8021 8022 +1
+ Misses 5968 5962 -6
+ Partials 762 758 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -48,6 +48,7 @@ | |||
private String dbType; | |||
private int transOperationTimeout = DEFAULT_TRANS_OPER_TIMEOUT; | |||
private SagaTransactionalTemplate sagaTransactionalTemplate; | |||
private boolean skipBranchReportOnSuccess; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/seata/seata/blob/a1a51e0c3d374ed0f9604012e9aac1f9822a7495/script/client/spring/application.yml#L9 There is a similar function switch in AT mode. If this configuration can be combined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -106,7 +106,7 @@ | |||
/** | |||
* The constant CLIENT_REPORT_SUCCESS_ENABLE. | |||
*/ | |||
public static final String CLIENT_REPORT_SUCCESS_ENABLE = CLIENT_PREFIX + "report.success.enable"; | |||
public static final String CLIENT_REPORT_SUCCESS_ENABLE = CLIENT_RM_PREFIX + "report.success.enable"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use dots as discussed for this configuration item.
* 'develop' of https://github.com/seata/seata: (125 commits) optimize: tcc module code style (apache#2103) refactor: change the package path of MySQL recognizer (apache#2125) optimize: fix query typo (apache#2176) refactor: add sql parser type druid as constant (apache#2156) test: enhance test coverage of seata common (apache#2170) optimize: gracefully close resources (apache#2139) Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. (apache#2151) chore:use serializer instead of codec (apache#2097) optimize: spring module code style (apache#2159) optimize: Add Dubbo compatibility (apache#2036) optimize : seata-rm-datasource module code style (apache#2062) bugfix: Saga report branch status incorrect when service retried succeed (apache#2145) optimize:optimize log specifications (apache#2146) bugfix: when branchRollback failed, it will trigger retry of multi-tc. (apache#2113) refactor: create sql parser spi and a druid type sql parser (apache#1703) refactor: simplify to make seata-common more readable (apache#2038) feature: support FastThreadLocalContextCore (apache#2106) optimize: some typos (apache#2120) optimize: increase the oracle table meta cache code coverage (apache#2078) optimize: some typos (apache#2115) ... # Conflicts: # pom.xml
Ⅰ. Describe what this PR did
Saga provide a switch to skip branch report on branch success, in order to optimize performance.
Ⅱ. Does this pull request fix one issue?
#2150
Ⅳ. Describe how to verify it
add config attribute
client.rm.report.success.enable=false
file.confexecute unit test
StateMachineDBTests.java