Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sessionManager unit test #222

Merged
merged 1 commit into from
Jan 22, 2019
Merged

add sessionManager unit test #222

merged 1 commit into from
Jan 22, 2019

Conversation

xm-king
Copy link
Contributor

@xm-king xm-king commented Jan 22, 2019

Ⅰ. Describe what this PR did

add SessionManager Unit Test

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #222 into develop will increase coverage by 3.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #222      +/-   ##
==========================================
+ Coverage     4.62%   8.21%   +3.58%     
==========================================
  Files          184     184              
  Lines         6770    6770              
  Branches       931     931              
==========================================
+ Hits           313     556     +243     
+ Misses        6439    6163     -276     
- Partials        18      51      +33
Impacted Files Coverage Δ
.../java/com/alibaba/fescar/server/UUIDGenerator.java 17.39% <0%> (+17.39%) ⬆️
...scar/server/store/FileTransactionStoreManager.java 25.53% <0%> (+25.53%) ⬆️
...m/alibaba/fescar/server/session/GlobalSession.java 27.97% <0%> (+27.97%) ⬆️
...aba/fescar/server/store/TransactionWriteStore.java 36.11% <0%> (+36.11%) ⬆️
...m/alibaba/fescar/server/session/BranchSession.java 36.76% <0%> (+36.76%) ⬆️
...a/fescar/server/store/TransactionStoreManager.java 42.3% <0%> (+42.3%) ⬆️
...a/fescar/server/session/DefaultSessionManager.java 57.14% <0%> (+57.14%) ⬆️
...ba/fescar/server/store/TransactionWriteFuture.java 58.06% <0%> (+58.06%) ⬆️
...libaba/fescar/server/session/SessionCondition.java 60% <0%> (+60%) ⬆️
.../fescar/server/session/AbstractSessionManager.java 85.18% <0%> (+85.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4cc04c...a963afb. Read the comment docs.

@slievrly
Copy link
Member

@xm-king good job.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval

@wangliang181230 wangliang181230 added this to the 0.1.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants