Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: release 1.1.0 #2272

Merged
merged 2 commits into from
Feb 19, 2020
Merged

release: release 1.1.0 #2272

merged 2 commits into from
Feb 19, 2020

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

release: release 1.1.0

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@slievrly
Copy link
Member Author

  • seata-all + @EnableAutoDataSourceProxy(useJdkProxy = true) + mysql + file commit/rollback valid
  • seata-all + @EnableAutoDataSourceProxy(useJdkProxy = true) + mysql + nacos commit/rollback valid
  • seata-all + datasourceProxy + mysql +file commit/rollback valid
  • seata-all + datasourceProxy + mysql +nacos commit/rollback valid
  • SCA sample + seata-spring-boot-starter +mysql + propertites commit/rollback valid

@slievrly slievrly added this to the 1.1.0 milestone Feb 19, 2020
@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #2272 into develop will decrease coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2272      +/-   ##
============================================
- Coverage      50.13%   50.1%   -0.03%     
+ Complexity      2665    2662       -3     
============================================
  Files            518     518              
  Lines          17030   17031       +1     
  Branches        2061    2062       +1     
============================================
- Hits            8538    8534       -4     
- Misses          7688    7690       +2     
- Partials         804     807       +3
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/config/FileConfiguration.java 36.5% <0%> (-0.3%) 6 <0> (ø)
...igure/properties/file/ThreadFactoryProperties.java 45.94% <100%> (ø) 8 <0> (ø) ⬇️
.../java/io/seata/core/rpc/netty/NettyBaseConfig.java 36.11% <100%> (ø) 2 <0> (ø) ⬇️
...obuf/convertor/BranchRegisterRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...otobuf/convertor/GlobalBeginResponseConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...otobuf/convertor/GlobalStatusRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...otobuf/convertor/GlobalCommitRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...obuf/convertor/GlobalRollbackRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...protobuf/convertor/RegisterTMRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...protobuf/convertor/RegisterRMRequestConvertor.java 95.23% <0%> (ø) 3% <0%> (ø) ⬇️
... and 17 more

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test case below:
Mysql

insert into account_tbl(user_id, money, information) values (?, ?, ?)
insert into `account_tbl`(user_id, money, information) values (?, ?, ?)
insert into seatA.account_tbl(user_id, money, information) values (?, ?, ?)
insert into seatA.`account_tbl`(user_id, money, information) values (?, ?, ?)
delete from account_tbl where user_id = ?", userId)
delete from `account_tbl` where user_id = ?", userId)
delete from seata.account_tbl where user_id = ?", userId)
delete from seata.`account_tbl` where user_id = ?", userId)
update account_tbl set money = money - ? where user_id = ?
update `account_tbl` set money = money - ? where user_id = ?
update seata.account_tbl set money = money - ? where user_id = ?
update seata.`account_tbl` set money = money - ? where user_id = ?
select * from account_tbl where id = ? for update
select * from `account_tbl` where id = ? for update
select * from seata.account_tbl where id = ? for update
select * from seata.`account_tbl` where id = ? for update

Oracle

insert into account_tbl(id, user_id, money, information, description) values (account_tbl_seq.nextval, ?, ?, ?, ?)
insert into \"ACCOUNT_TBL\"(id, user_id, money, information, description) values (account_tbl_seq.nextval, ?, ?, ?, ?)
insert into test.account_tbl(id, user_id, money, information, description) values (account_tbl_seq.nextval, ?, ?, ?, ?)
insert into test.\"ACCOUNT_TBL\"(id, user_id, money, information, description) values (account_tbl_seq.nextval, ?, ?, ?, ?)
delete from account_tbl where user_id = ?
delete from \"ACCOUNT_TBL\" where user_id = ?
delete from test.account_tbl where user_id = ?
delete from test.\"ACCOUNT_TBL\" where user_id = ?
update account_tbl set money = money - ? where user_id = ?
update \"ACCOUNT_TBL\" set money = money - ? where user_id = ?
update test.account_tbl set money = money - ? where user_id = ?
update test.\"ACCOUNT_TBL\" set money = money - ? where user_id = ?
select * from account_tbl where id = ? for update
select * from \"ACCOUNT_TBL\" where id = ? for update
select * from test.account_tbl where id = ? for update
select * from test.\"ACCOUNT_TBL\" where id = ? for update

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added the Do Not Merge Do not merge into develop label Feb 19, 2020
@slievrly slievrly removed the Do Not Merge Do not merge into develop label Feb 19, 2020
@slievrly slievrly merged commit e81ae8d into apache:develop Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants