-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: release 1.1.0 #2272
Merged
Merged
release: release 1.1.0 #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
|
Codecov Report
@@ Coverage Diff @@
## develop #2272 +/- ##
============================================
- Coverage 50.13% 50.1% -0.03%
+ Complexity 2665 2662 -3
============================================
Files 518 518
Lines 17030 17031 +1
Branches 2061 2062 +1
============================================
- Hits 8538 8534 -4
- Misses 7688 7690 +2
- Partials 804 807 +3
|
l81893521
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Test case below:
Mysql
insert into account_tbl(user_id, money, information) values (?, ?, ?)
insert into `account_tbl`(user_id, money, information) values (?, ?, ?)
insert into seatA.account_tbl(user_id, money, information) values (?, ?, ?)
insert into seatA.`account_tbl`(user_id, money, information) values (?, ?, ?)
delete from account_tbl where user_id = ?", userId)
delete from `account_tbl` where user_id = ?", userId)
delete from seata.account_tbl where user_id = ?", userId)
delete from seata.`account_tbl` where user_id = ?", userId)
update account_tbl set money = money - ? where user_id = ?
update `account_tbl` set money = money - ? where user_id = ?
update seata.account_tbl set money = money - ? where user_id = ?
update seata.`account_tbl` set money = money - ? where user_id = ?
select * from account_tbl where id = ? for update
select * from `account_tbl` where id = ? for update
select * from seata.account_tbl where id = ? for update
select * from seata.`account_tbl` where id = ? for update
Oracle
insert into account_tbl(id, user_id, money, information, description) values (account_tbl_seq.nextval, ?, ?, ?, ?)
insert into \"ACCOUNT_TBL\"(id, user_id, money, information, description) values (account_tbl_seq.nextval, ?, ?, ?, ?)
insert into test.account_tbl(id, user_id, money, information, description) values (account_tbl_seq.nextval, ?, ?, ?, ?)
insert into test.\"ACCOUNT_TBL\"(id, user_id, money, information, description) values (account_tbl_seq.nextval, ?, ?, ?, ?)
delete from account_tbl where user_id = ?
delete from \"ACCOUNT_TBL\" where user_id = ?
delete from test.account_tbl where user_id = ?
delete from test.\"ACCOUNT_TBL\" where user_id = ?
update account_tbl set money = money - ? where user_id = ?
update \"ACCOUNT_TBL\" set money = money - ? where user_id = ?
update test.account_tbl set money = money - ? where user_id = ?
update test.\"ACCOUNT_TBL\" set money = money - ? where user_id = ?
select * from account_tbl where id = ? for update
select * from \"ACCOUNT_TBL\" where id = ? for update
select * from test.account_tbl where id = ? for update
select * from test.\"ACCOUNT_TBL\" where id = ? for update
zjinlei
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
release: release 1.1.0
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews