-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:Saga add switch to control whether to register branch #2308
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2308 +/- ##
=============================================
- Coverage 51.42% 51.26% -0.17%
+ Complexity 2807 2805 -2
=============================================
Files 553 553
Lines 17691 17678 -13
Branches 2091 2054 -37
=============================================
- Hits 9098 9062 -36
+ Misses 7738 7735 -3
- Partials 855 881 +26
|
@long187 does the current configuration of saga need to be passed in through the bean configuration? Whether to consider merging with the seata configuration file. A similar configuration item is' seata.client.rm. Reports-success-enable =false ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…not_registerbranch
…7/seata into saga_donot_registerbranch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Ⅰ. Describe what this PR did
Feature:Saga mode add switch to control whether to register branch
In Saga mode, branches are stored by StateMachineEngin at the client, branch rollaback and commit are coordinated by StateMachineEngine, for higher performance, users can switch off register branches by property
sagaBranchRegisterEnable
Ⅳ. Describe how to verify it
or
seata configuration file
Run unit test: /seata/test/src/test/java/io/seata/saga/engine/db/StateMachineDBTests.java