-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:fix wrong proxy of datasource bean #2323
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2323 +/- ##
=============================================
- Coverage 51.74% 51.71% -0.03%
+ Complexity 2665 2664 -1
=============================================
Files 518 519 +1
Lines 16805 16810 +5
Branches 2031 2032 +1
=============================================
- Hits 8695 8694 -1
- Misses 7293 7298 +5
- Partials 817 818 +1
|
...ng/src/main/java/io/seata/spring/annotation/datasource/SeataDataSourceBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/io/seata/spring/annotation/datasource/SeataDataSourceBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/io/seata/spring/annotation/datasource/SeataDataSourceBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/io/seata/spring/annotation/datasource/SeataDataSourceBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
@xingfudeshi So here are some advices:
|
Please review. |
spring/src/main/java/io/seata/spring/annotation/datasource/EnableAutoDataSourceProxy.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/annotation/datasource/SeataAutoDataSourceProxyCreator.java
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/annotation/datasource/SeataAutoDataSourceProxyCreator.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/annotation/datasource/AutoDataSourceProxyRegistrar.java
Outdated
Show resolved
Hide resolved
…seata into fix_duplicate_proxy
...oot-starter/src/main/java/io/seata/spring/boot/autoconfigure/properties/SeataProperties.java
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/annotation/datasource/SeataAutoDataSourceProxyAdvice.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix wrong proxy of datasource bean
Ⅱ. Does this pull request fix one issue?
fixes #2322 #2311 #2321
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done integration testing.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews