-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: has other expression before insert row primary key. #2725
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2725 +/- ##
=============================================
+ Coverage 50.36% 50.46% +0.10%
+ Complexity 2889 2886 -3
=============================================
Files 572 572
Lines 18594 18590 -4
Branches 2204 2232 +28
=============================================
+ Hits 9364 9382 +18
Misses 8285 8285
+ Partials 945 923 -22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
But i think if rank the pk first, maybe logic is simple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix: has other expression before insert row primary key.
Ⅱ. Does this pull request fix one issue?
fixes #2710
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews