Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ColumnUtils delEscape with scheme error. #2875

Merged
merged 5 commits into from
Jul 10, 2020
Merged

bugfix: ColumnUtils delEscape with scheme error. #2875

merged 5 commits into from
Jul 10, 2020

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Jul 9, 2020

Ⅰ. Describe what this PR did

fix ColumnUtils#delEscape like `scheme`.`table` error, optimize KeywordChecker checkAndReplace method.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2020

Codecov Report

Merging #2875 into develop will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2875      +/-   ##
=============================================
- Coverage      50.13%   50.10%   -0.04%     
+ Complexity      3022     3017       -5     
=============================================
  Files            598      598              
  Lines          19304    19297       -7     
  Branches        2350     2351       +1     
=============================================
- Hits            9678     9668      -10     
+ Misses          8664     8662       -2     
- Partials         962      967       +5     
Impacted Files Coverage Δ Complexity Δ
...source/undo/mysql/keyword/MySQLKeywordChecker.java 98.90% <ø> (-0.01%) 3.00 <0.00> (-2.00)
...urce/undo/oracle/keyword/OracleKeywordChecker.java 94.69% <ø> (-2.30%) 7.00 <0.00> (-4.00)
...o/postgresql/keyword/PostgresqlKeywordChecker.java 91.00% <ø> (+1.47%) 6.00 <0.00> (-1.00) ⬆️
.../main/java/io/seata/rm/datasource/ColumnUtils.java 80.00% <100.00%> (+1.42%) 20.00 <0.00> (+1.00)
...va/io/seata/rm/datasource/exec/DeleteExecutor.java 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
.../seata/rm/datasource/exec/MultiDeleteExecutor.java 100.00% <100.00%> (ø) 9.00 <0.00> (ø)
...tasource/sql/struct/cache/MysqlTableMetaCache.java 82.35% <100.00%> (-0.21%) 10.00 <1.00> (ø)
...rce/sql/struct/cache/PostgresqlTableMetaCache.java 75.86% <100.00%> (-0.28%) 10.00 <0.00> (ø)
...ource/sql/struct/cache/AbstractTableMetaCache.java 71.42% <0.00%> (-14.29%) 8.00% <0.00%> (ø%)
... and 3 more

@jsbxyyx jsbxyyx requested a review from l81893521 July 9, 2020 09:53
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added the module/rm-datasource rm-datasource module label Jul 9, 2020
@slievrly slievrly added this to the 1.3.0 milestone Jul 9, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit b0f4d99 into apache:develop Jul 10, 2020
@yueyuanyu
Copy link

大佬 我们在整合seata时遇到了很多问题.其中一个问题就是这个schema '数据库名'.'表名' 我们自己定位delxxx那个方法上手动改变成去除" . " 情况后事务正常回滚,但是合并了你的pr后,现在的情况是分支事务正常回滚,但是调用方却疯狂的耍SQL异常 有脏数据.Caused by: java.sql.SQLException: Has dirty records when undo. 尝试清除seata库里的数据,undolog表数据.重新测试依旧是这个情况,应该是合并了你这个pr后发生的情况. 我们dao层用的jooq.springcloud为E,springboot1.5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants