-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: enable NamedThreadFactory to get ThreadGroup from the SecurityManager or Current thread #3310
Conversation
enable NamedThreadFactory to get ThreadGroup from the SecurityManager Reference JDK's implementation of DefaultThreadFactory Ⅱ. Does this pull request fix one issue? Ⅲ. Why don't you add test cases (unit test/integration test)? Ⅳ. Describe how to verify it Ⅴ. Special notes for reviews
@@ -65,4 +65,11 @@ public void testThreadNameHasCounterWithPrefixCounter() { | |||
.isEqualTo(thread.getName()); | |||
} | |||
} | |||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line before @test would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line before @test would be better.
Thank you for your suggestion. I have dealt with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add an empty line before @test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line before @test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
enable NamedThreadFactory to get ThreadGroup from the SecurityManager or Current thread
Reference JDK's implementation of DefaultThreadFactory
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews