optimize: get netty config property from system properties. #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ls9527
reviewed
Dec 4, 2020
| private int serverSelectorThreads = WORKER_THREAD_SIZE; | ||
| private int serverSocketSendBufSize = 153600; | ||
| private int serverSocketResvBufSize = 153600; | ||
| private int serverSelectorThreads = Integer.parseInt(System.getProperty( |
There was a problem hiding this comment.
这样的配置确实看起来很方便， 只是和目前的配置方式不统一了。
比如你可以参考父类 NettyBaseConfig.BOSS_THREAD_PREFIX 的属性赋值，每种方式都可以支持你目前的写法， 有限从系统属性中获取， 获取不到会从配置中心获取。
|
需要讨论两个点：
|
|
@CoffeeLatte007 @ls9527 我的想法是开启这个配置入口，但是又不想让用户通过配置文件的方式去更改。毕竟这些东西不怎么变动，但是有时候又需要修改。 |
这个理由赞同 |
CoffeeLatte007
approved these changes
Dec 10, 2020
refeccd
reviewed
Dec 15, 2020
| private int serverSocketResvBufSize = 153600; | ||
| private int serverSelectorThreads = Integer.parseInt(System.getProperty( | ||
| ConfigurationKeys.TRANSPORT_PREFIX + "serverSelectorThreads", String.valueOf(WORKER_THREAD_SIZE))); | ||
| private int serverSocketSendBufSize = Integer.parseInt(System.getProperty( |
There was a problem hiding this comment.
private int serverSocketSendBufSize = Integer.getInteger(TRANSPORT_PREFIX + "serverSocketSendBufSize", 153600);
改成这样是不是更直观点
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize: get netty config property from system properties.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews