-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: globalTransactionScanner listener optimize #3380
Conversation
When disableGlobalTransaction = true at startup, why don't you need to listen to configuration changes for on disableGlobalTransaction? |
@lj2018110133 merge the latest develop branch code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #3380 +/- ##
=============================================
- Coverage 51.55% 51.55% -0.01%
- Complexity 3342 3344 +2
=============================================
Files 616 616
Lines 20247 20247
Branches 2541 2539 -2
=============================================
- Hits 10439 10438 -1
- Misses 8757 8758 +1
Partials 1051 1051
|
Ⅰ. Describe what this PR did
globalTransactionScanner listener optimize
Ⅱ. Does this pull request fix one issue?
fixes #3377
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews