-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: run with jar file and not package third lib into jar file, this.getClass().getClassLoader() will be null #3408
Conversation
Error: /home/runner/work/seata/seata/config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java:170:9: 'if' is not followed by whitespace. [WhitespaceAround] 这几个代码按照阿里p3c代码格式化一下 |
好了. |
Codecov Report
@@ Coverage Diff @@
## develop #3408 +/- ##
==========================================
Coverage 51.56% 51.57%
- Complexity 3341 3343 +2
==========================================
Files 616 616
Lines 20243 20251 +8
Branches 2541 2542 +1
==========================================
+ Hits 10439 10444 +5
- Misses 8752 8756 +4
+ Partials 1052 1051 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
jar运行模式, 当第三方依赖分开打包时, this.getClass().getClassLoader()是null, 会报空指针异常
Ⅱ. Does this pull request fix one issue?
#3407
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews